-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uninstalling a plugin #1531 #1538
base: master
Are you sure you want to change the base?
Conversation
Merry Christmas too, thanks a lot for your contribution. 🙏 |
Are we ready to merge or is there any more changes @gounthar @dduportal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The install-plugins.sh script is no longer a useful script. The plugins.txt file defines the plugins to be installed, not the plugins to be removed (at least as far as I've used it).
From experiments with the jenkins/jenkins:2.375.1 container, I can remove a plugin from the installation by removing the entry from the Dockerfile that I used was:
However, that simple use case does not cover the cases where the user is preserving their configuration in a separate data volume. In that case, then I believe that additional steps will be required in order to remove the files from |
… of creating a new plugin.txt
Added a new commit- b0b6bcf Let me know, if there are any suggestions. |
Any update on this |
Sorry for the delay. It will likely be a few more days before I can review. |
Same for me, sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution, we do appreciate it. 🙏
Please have a look at my comments and let me know if you agree.
If you don't (which is fine), let's discuss it further.
Once more, thanks.
@MarkEWaite can you help me with the new updates that I need to add or remove from this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this is general documentation that applies to all Jenkinses. Why is it added to the documentation of the Docker images?
Because it's needed here until a "general documentation with clear examples for Docker" is provided. There are multiple specific elements for Docker image that are required, which does NOT apply to packaged distribution of Jenkins (the fact that plugins should be pre-installed in the image in |
Hey @dduportal, can you help me with this PR. Its been one month without any update from other maintainers. |
Sorry for the delay @ritikbanger . I'll do my best to help with a review within the next 7 days. @dduportal probably won't be able to help due to other priorities that he needs to handle. |
@dduportal I have updated the PR with your feedback. Please have a look. |
@gounthar your review will be highly appreciated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this work. 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this work. 🤗
@gounthar I think we are ready to merge this. |
Thank you very much for your contribution and the latest changes, @ritikbanger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's going in a really good direction! I'm still not in agreement with some major elements.
The main point is that it feels like you want to write a step by step guide: the README is not the place for that. I would prefer having a page in jenkins.io's documentation (which requires asking the documentation SIG group to find the perfect place in the table of content).
I've provided feedback to continue this PR and land it by shrinking steps and being more generic (requiring Docker Compose is not acceptable for instance).
Thanks for this work!
Hi @ritikbanger , any news? This PR has been opened for quite some time and it would benefit from an update. |
I would be updating this PR shortly. |
Thanks. 🤗 |
@dduportal Please have a look. |
Thanks @ritikbanger . I'll check before end of month as I only have low availability for now. |
Any update on this |
Its been 2 years since this PR, if we are not merging it, kindly close it. |
Hi @ritikbanger , many thanks for the content, work and pings. Sorry for not being able to take the required time. it’s been a long time so i do not remember all the details, but reviewing it again (eg. From scratch) , i feel line this content should mostly be in www.jenkins.io as it is a good step by step which is oriented not only for Docker containers but also jenkins in general. And the readme here should point the user to the www.jenkins.io. wdyt @MarkEWaite @gounthar @kmartens27 ? |
I believe this kind of information would be better suited for the jenkins.io website. |
I agree with @gounthar that this would be very helpful information to have on jenkins.io, as uninstalling a plugin is a fairly common practice that would be good to have documented. |
Could you share me which specific section of this repo should i put this into |
Sure thing @ritikbanger! I think the Managing Plugins section of documentation would be the most appropriate. There is already a section for Removing/Uninstalling plugins, so this could be a unique section under that area with it's own "Uninstalling a plugin with Docker" header. |
I agree with @kmartens27 suggestion. A subsection within the existing Uninstalling a Plugin page would indeed be an ideal location for this information. When adding the new subsection, we should:
|
Document removal of a plugin from container
This PR address the following issue: #1531 which is discussed in SIG December 16th Meeting
cc @dduportal @gounthar
Merry Christmas 🎅