Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Drafter "Changes" title looks odd #5

Closed
oleg-nenashev opened this issue Jun 14, 2019 · 6 comments
Closed

Release Drafter "Changes" title looks odd #5

oleg-nenashev opened this issue Jun 14, 2019 · 6 comments

Comments

@oleg-nenashev
Copy link
Member

Currently Release Drafter generates the following output:

## Changes
## 🚀 New features and improvements

* [JENKINS-57425](https://issues.jenkins-ci.org/browse/JENKINS-57425) - Add profile to run benchmarks only when the `benchmark` property is set (#206) @AbhyudayaSharma

## Changes section is designed for uncategorized commits, but we usually do not have ones. I suggest dropping it from the default template

CC @Casz @halkeye @timja

@jetersen
Copy link
Member

I'm fine with it, I left it there as a reminder to use it as a spot to write something beyond the pull request titles (see https://github.com/jenkinsci/configuration-as-code-plugin/releases/tag/configuration-as-code-1.18 example). 😅

@oleg-nenashev
Copy link
Member Author

Fair point. What if we add <!-- Optional: add a release summary here --> instead? In such case it will appear for maintainers but not for changelog viewers

@jetersen
Copy link
Member

Sounds good too 👍

@oleg-nenashev
Copy link
Member Author

@oleg-nenashev
Copy link
Member Author

#6

@oleg-nenashev
Copy link
Member Author

Should work now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants