We may no longer need length limitations for groupId, artifactId

[daniel-beck]

What feature do you want to see added?

After jenkins-infra/update-center2#605, we may no longer have a need for length limitations for groupId, artifactId.

RPU itself can handle names based on overly long artifact IDs in

repository-permissions-updater/src/main/groovy/io/jenkins/infra/repository_permissions_updater/ArtifactoryAPI.groovy

Lines 138 to 140 in 4ae7713

	// Artifactory has an undocumented max length for permission target names of 64 chars (and possibly other types)
	// If length is exceeded, use 55 chars of the prefix+name, separator, and 8 hopefully unique chars (prefix of name's SHA-256)
	name = name.substring(0, 54) + '_' + sha256(name).substring(0, 7)

.

Otherwise I'm not sure we need to limit lengths for infra reasons. We can probably relax the current lengths and allow longer values, but perhaps not fully unrestricted?

Upstream changes

No response

[daniel-beck]

#2681 likely identifies a length limitation in GitHub repo names, which usually correspond with artifact ID.

[jetersen]

Can this be closed as well @daniel-beck ? or is it related to another API.

[daniel-beck]

Given that #2681 was a new discovery when I commented, it's unrelated.

[timja]

It's related as it was a reason to not lift the limitation isn't it?

Now that it's resolved we can possibly go ahead and remove the limitation?

[daniel-beck]

Now that it's resolved we can possibly go ahead and remove the limitation?

If there's no other reason to limit lengths. I don't know. Yoloing would not be a good idea.

[timja]

There's no known issues but I haven't rushed to remove this as I don't think it's harmful to have reasonable length names (i.e. not too long)