Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the deploy Dockerfile too #107

Open
lemeurherve opened this issue Oct 26, 2021 · 6 comments
Open

Update the deploy Dockerfile too #107

lemeurherve opened this issue Oct 26, 2021 · 6 comments

Comments

@lemeurherve
Copy link
Member

lemeurherve commented Oct 26, 2021

Follow-up of #105

The Dockerfile at

FROM jetty:9-alpine
should use the same image as
FROM jetty:9-jdk8-eclipse-temurin

@sridamul
Copy link

Hey, @lemeurherve!
Is there any reason to stick to jdk8?
else
Merging PR #124 will resolve this issue right?

@halkeye
Copy link
Member

halkeye commented Feb 19, 2024

I would assume this super old project doesn't run in newer java

@halkeye
Copy link
Member

halkeye commented Feb 19, 2024

@lemeurherve I would argue a ticket with no details whats so ever is not a good first issue

@lemeurherve
Copy link
Member Author

lemeurherve commented Feb 21, 2024

Agree, my bad.

@halkeye
Copy link
Member

halkeye commented Feb 21, 2024

It happens. I fight that fight a lot at work so could have been more polite sorry.

So the request is copy
https://github.com/jenkins-infra/plugin-site-api/blob/master/Dockerfile#L1
To
https://github.com/jenkins-infra/plugin-site-api/blob/master/deploy/Dockerfile then confirm it works?

@lemeurherve
Copy link
Member Author

lemeurherve commented Feb 21, 2024

Yes exactly, thanks! And no worry I didn't find it not polite ;)

Issue body updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants