Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrading a stats.jenkins.io maintainer to having no rights #4450

Open
krisstern opened this issue Dec 15, 2024 · 25 comments
Open

Downgrading a stats.jenkins.io maintainer to having no rights #4450

krisstern opened this issue Dec 15, 2024 · 25 comments
Assignees
Labels
github-permissions Request for GitHub permissiosn

Comments

@krisstern
Copy link
Member

krisstern commented Dec 15, 2024

GitHub repositories

https://github.com/jenkins-infra/stats.jenkins.io

GitHub users to have permission

@Vandit1604

Permission level

None

Justification

Based on some private discussions with @MarkEWaite and also some previous direct experiences with the contributor, we would like to remove any write access they have on all Jenkins-related repositories which is only https://github.com/jenkins-infra/stats.jenkins.io currently, as we would not see any services to be broken by anyone unintentionally merging poorly reviewed pull requests.

@krisstern krisstern added github-permissions Request for GitHub permissiosn triage Incoming issues that need review labels Dec 15, 2024
@Vandit1604
Copy link

I have decided to step down as the maintainer of stats.jenkins.io. This decision stems from concerns about how certain matters were handled by one of the fellow maintainer, as referenced in this closed issue:

Thank you for the opportunity to contribute to this project.

Regards

@krisstern
Copy link
Member Author

Thanks @Vandit1604 for the updates! We will remove all your privileges then.

@krisstern krisstern changed the title Downgrading a stats.jenkins.io maintainer to having "triage" rights only Downgrading a stats.jenkins.io maintainer to having no rights Dec 15, 2024
@krisstern
Copy link
Member Author

This is the PR concerned that @Vandit1604 merged without properly reviewing and without consulting the other maintainers: jenkins-infra/stats.jenkins.io#190

@krisstern
Copy link
Member Author

It appears that @Vandit1604 does not possess the expertise required nor have acted with common sense or caution when carrying out maintainer duties, which is the root cause for the creatiion of this issue. There are some other issues concerning this contributor as well, mostly competency-based and behavioral, as evident in

@Vandit1604
Copy link

For the record:

I have been actively monitoring renovate dependency updates and even investigated this PR: jenkins-infra/stats.jenkins.io#222. I have consistently raised issues, reviewed PRs, and supported other contributors, including assisting @krisstern.

I acknowledge my mistake in merging jenkins-infra/stats.jenkins.io#190 without consulting other maintainers. At the time, I was confident in my decision, but I should have sought additional input, including from @krisstern. I take full responsibility for that oversight.

As for behavior, there was an instance where I requested a link to an issue from @krisstern, which led to some tension. Ironically, in a similar situation today, when a passerby requested an issue link on jenkins-infra/stats.jenkins.io#215, the response did not directly address the request and he started tagging me saying stuff like

@Vandit1604 should have been able to do so but I am not sure why he couldn't, that may be a competency issue.

@Vandit1604 Thanks for your feedback, but this is not meant to be personal. You should have been able to locate it as you have contributed to Jenkins before. I am trying to explain why your statement made no sense.

@Vandit1604 Thanks for your prompt reponse! I do not know why you could not find the issue, could you at least find where the Intra teams issue tracker is, or did you have problems locating it? Or would you like us to focus back on the issue as you say and stop arguing because you feel offended?

While I accept constructive feedback, I also believe that mutual respect and understanding are vital to fostering a collaborative and productive environment.

@Vandit1604
Copy link

I won't mind being removed as maintainer, that's a decision that lies in the hands of people who have contributed a lot more than me to the project and I totally respect their decision.

But I didn't like how @krisstern was insulting me publically and commenting on my competency. That was nor kind, neither empathetic.

@Vandit1604
Copy link

@krisstern I kindly request that you refrain from tagging me further. You won’t see me around, and I’ll make sure not to bother you again. Wishing you the best moving forward.

@krisstern
Copy link
Member Author

krisstern commented Dec 15, 2024

Thanks @Vandit1604 for the feedback!

I honestly do not know what to say given you are very insistent that you are justified in claiming my wording is somehow not constructive to the conversation. But I also cannot find a better word then "competency". Do you have any suggestion that you would find more agreeble? I have not been insulting you in public. Maybe you may think it is harsh.

@krisstern
Copy link
Member Author

krisstern commented Dec 15, 2024

I think this argument is taken out of context.

It was Mark's suggestion to remove Vandit's maintainer rights and replace it with only triage access duing our discucssion. Also in private Vandit has asked me for maintainer rights to the docs.jennkins.io repo, which was not appropriate behavior since that right is only reserved for jenkins.io copy-editors. Since now Vandit is saying he is stepping down, we will accept it and request to have all rights of stats.jenkins.io repo removed from him.

@krisstern
Copy link
Member Author

krisstern commented Dec 15, 2024

For the record we have been more than disappointed with Vandit's performance since this participating in GSoC 2023 as a contributor. He did assist in co-mentoring one GSoC project in 2024, but I observed him trying to force his often highly opinionated views on the participant on more than one occasion at the beginning. His engagement dropped as he became less available following the start of his internship towards the end of the summer, but he did not warn us ahead of time. He also asked me to take over his tasks which he volunteered to do post and for his GSoC 2023 project via DM. He was hoarding the docs.jenkins.io retooling project for himself for apparently not very noble reasons when he could not commit the time or the effort to complete it in any way, shape, or form, despite me saying I could take over. This is my assessment of this contributor. Very likely what he meant by assisting me is to do the tasks I would normally do reviewing dependency-related PR's, which is not really needed as I can do these myself. He was welcome to do so as he liked, but I wouldn't considered it assisting me in any way, since the project belongs to Jenkins, and not me.

@Vandit1604
Copy link

I wanted to address some points raised by Kris and provide clarity regarding my contributions and actions during the mentorship period.

Firstly, the functionality for the documentation site has been implemented and is ready, requiring only content updates which Kris said he will do, and I don't have to worry about. The Gatsby site now includes the functionality we couldn't achieve with Antora due to its limitations with static content. My work during GSoC'23 was delivered to the expected standards, as reflected in the successful evaluation. At no point did I indicate I wouldn't complete my assigned tasks during the mentorship.

Key deliverables from my work include:

Upgrade Guide Implementation (Issue: #87): This feature is implemented but requires refinement.
Pipeline Step Reference (Issue: #86): This feature is also implemented but needs further polishing.

Regarding the delay in resuming work, I acted based on your directions to wait for Kevin Martens' return because he was unavailable due to personal reasons. When you informed me to pause, I did so in good faith. During that period, I had communicated that I was available whenever needed. However, I did not receive further instructions or indications to proceed.

For the record, I have not imposed my views or decisions on the GSoC'24 contributor. Participating in public discussions on GitHub and offering suggestions is part of collaboration, not interference. You can ask the GSoC'24 contributor if I ever imposed my opinions on anything. I was helping in reviewing code and pointed out bugs whenever I found one during the GSoC'24 mentorship period.

Lastly, while I have contributed as a maintainer to projects like stats.jenkins.io to help the team, I have consistently approached the work with a collaborative mindset. It’s disheartening to face accusations of being dismissive when my focus has always been on addressing the problem rather than personal differences.

I hope this clarifies my position and actions. If there are specific concerns or expectations moving forward, I’m open to addressing them.
Also, I would like this conversation to diffuse to keep things collaborative and professional.

@krisstern
Copy link
Member Author

For the record:

I have been actively monitoring renovate dependency updates and even investigated this PR: jenkins-infra/stats.jenkins.io#222. I have consistently raised issues, reviewed PRs, and supported other contributors, including assisting @krisstern.

I acknowledge my mistake in merging jenkins-infra/stats.jenkins.io#190 without consulting other maintainers. At the time, I was confident in my decision, but I should have sought additional input, including from @krisstern. I take full responsibility for that oversight.

As for behavior, there was an instance where I requested a link to an issue from @krisstern, which led to some tension. Ironically, in a similar situation today, when a passerby requested an issue link on jenkins-infra/stats.jenkins.io#215, the response did not directly address the request and he started tagging me saying stuff like

@Vandit1604 should have been able to do so but I am not sure why he couldn't, that may be a competency issue.

@Vandit1604 Thanks for your feedback, but this is not meant to be personal. You should have been able to locate it as you have contributed to Jenkins before. I am trying to explain why your statement made no sense.

@Vandit1604 Thanks for your prompt reponse! I do not know why you could not find the issue, could you at least find where the Intra teams issue tracker is, or did you have problems locating it? Or would you like us to focus back on the issue as you say and stop arguing because you feel offended?

While I accept constructive feedback, I also believe that mutual respect and understanding are vital to fostering a collaborative and productive environment.

Also, the reason why I did not cite the helpdesk issue on the issue Vandit created was because I feared he may interfere with my following up on that, exactly like what he is doing to this issue which I have created. The reason why I closed that issue was because the data should not have been available locallly if done properly, which apparently he did not. But honestly he should be able to locate the helpdesk issue if he wanted to given he knows where the helpdesk issue tracker is, if he is competent enough to do so. It still perplexing to me as to why he could not find it in the first place and needed to ask for assistance.

@krisstern
Copy link
Member Author

@Vandit1604 Could you please stop commenting on an issue on unrelated matters which I have created for another purpose?

You really seem to have something against me. For the record I was the lead mentor of the concerned GSoC projects, and it is my job to monitor you as a junior co-mentor, not you yourself.

@krisstern
Copy link
Member Author

I wanted to address some points raised by Kris and provide clarity regarding my contributions and actions during the mentorship period.

Firstly, the functionality for the documentation site has been implemented and is ready, requiring only content updates which Kris said he will do, and I don't have to worry about. The Gatsby site now includes the functionality we couldn't achieve with Antora due to its limitations with static content. My work during GSoC'23 was delivered to the expected standards, as reflected in the successful evaluation. At no point did I indicate I wouldn't complete my assigned tasks during the mentorship.

Key deliverables from my work include:

Upgrade Guide Implementation (Issue: #87): This feature is implemented but requires refinement. Pipeline Step Reference (Issue: #86): This feature is also implemented but needs further polishing.

Regarding the delay in resuming work, I acted based on your directions to wait for Kevin Martens' return because he was unavailable due to personal reasons. When you informed me to pause, I did so in good faith. During that period, I had communicated that I was available whenever needed. However, I did not receive further instructions or indications to proceed.

For the record, I have not imposed my views or decisions on the GSoC'24 contributor. Participating in public discussions on GitHub and offering suggestions is part of collaboration, not interference. You can ask the GSoC'24 contributor if I ever imposed my opinions on anything. I was helping in reviewing code and pointed out bugs whenever I found one during the GSoC'24 mentorship period.

Lastly, while I have contributed as a maintainer to projects like stats.jenkins.io to help the team, I have consistently approached the work with a collaborative mindset. It’s disheartening to face accusations of being dismissive when my focus has always been on addressing the problem rather than personal differences.

I hope this clarifies my position and actions. If there are specific concerns or expectations moving forward, I’m open to addressing them. Also, I would like this conversation to diffuse to keep things collaborative and professional.

A lot of what said here are lies.

@Vandit1604
Copy link

Wow.

@krisstern
Copy link
Member Author

krisstern commented Dec 15, 2024

Let me have another discussion with @MarkEWaite to see what to do to follow up on these unfound accusations.

@krisstern
Copy link
Member Author

Wow.

@Vandit1604 Please use professional language and not to cause a sensation here.

@krisstern
Copy link
Member Author

krisstern commented Dec 15, 2024

I wanted to address some points raised by Kris and provide clarity regarding my contributions and actions during the mentorship period.

Firstly, the functionality for the documentation site has been implemented and is ready, requiring only content updates which Kris said he will do, and I don't have to worry about. The Gatsby site now includes the functionality we couldn't achieve with Antora due to its limitations with static content. My work during GSoC'23 was delivered to the expected standards, as reflected in the successful evaluation. At no point did I indicate I wouldn't complete my assigned tasks during the mentorship.

Key deliverables from my work include:

Upgrade Guide Implementation (Issue: #87): This feature is implemented but requires refinement. Pipeline Step Reference (Issue: #86): This feature is also implemented but needs further polishing.

Regarding the delay in resuming work, I acted based on your directions to wait for Kevin Martens' return because he was unavailable due to personal reasons. When you informed me to pause, I did so in good faith. During that period, I had communicated that I was available whenever needed. However, I did not receive further instructions or indications to proceed.

For the record, I have not imposed my views or decisions on the GSoC'24 contributor. Participating in public discussions on GitHub and offering suggestions is part of collaboration, not interference. You can ask the GSoC'24 contributor if I ever imposed my opinions on anything. I was helping in reviewing code and pointed out bugs whenever I found one during the GSoC'24 mentorship period.

Lastly, while I have contributed as a maintainer to projects like stats.jenkins.io to help the team, I have consistently approached the work with a collaborative mindset. It’s disheartening to face accusations of being dismissive when my focus has always been on addressing the problem rather than personal differences.

I hope this clarifies my position and actions. If there are specific concerns or expectations moving forward, I’m open to addressing them. Also, I would like this conversation to diffuse to keep things collaborative and professional.

Also @Vandit1604 please note I do not owe you any more time than is given beyond those I pledged for the GSoC 2023 retooling project. I am not obligated to mentor you any more than I originally agreed to. I feel you think I have the obligation to tell you what to do in open-source after that project is over, which is not true. I also regret suggesting to add you as a co-maintainer of the stats.jenkins.io project, which you never really expressed any gratitude for nor were you being very collaborative on very many occasions. And, judging from our discussion here you are not respectful to me at all.

@krisstern
Copy link
Member Author

So @dduportal please strip @Vandit1604 of all access to the stats.jenkins.io repo when you are free to do so.

@Vandit1604
Copy link

I have been grateful to you and has implied that via our private conversations as well.
My perspective is that I go through a hard time because of you when I get tagged out of the blue on an issue, and you're criticizing me even though, I was not the part of the conversation. Criticism is not a problem to me, repetitive public criticism with harsh words is.

Other than that, I'm grateful to you for everything you did.

@krisstern
Copy link
Member Author

@Vandit1604 I feel more disappointed in you than anything because when we selected you to be a contributor you did show much potential. But you turned out to be not very reliable nor mature at all. I think you may have misremembered things and have mispresented what really transpired, and I also feel you feel entitled to my time. But you know what they used to say, "Time is money." And, while I enjoy contributing to open source I do have other tasks in my life I need to attend to too, like my family and friends who genuinely care about me.

@jenkins-infra jenkins-infra locked as too heated and limited conversation to collaborators Dec 15, 2024
@timja
Copy link
Member

timja commented Dec 15, 2024

Can both of you please step away from this for a bit.

We'll take a look at this tomorrow.

@jenkins-infra jenkins-infra unlocked this conversation Dec 16, 2024
@MarkEWaite
Copy link

I'd like a mediation meeting between me, @krisstern, and @Vandit1604 so that we can review what has happened, discuss why it happened, and decide on next steps. I think that meeting will need at least 60 minutes. I'll send a proposal for some alternative meeting times to @krisstern and @Vandit1604 trying to find a time when we can meet.

After the meeting, I'll provide a summary of the meeting results and we'll start on next steps.

@Vandit1604
Copy link

Sure @MarkEWaite
I have a request, Can we discuss the meeting times via mail please?
I'm unable to login into Element/Matrix. It shows that my account has been deactivated, and I'm unable to claim my account as well.

Thanks.

@MarkEWaite
Copy link

I have a request, Can we discuss the meeting times via mail please?

Started the discussion of meeting times by email.

@smerle33 smerle33 removed the triage Incoming issues that need review label Dec 16, 2024
@smerle33 smerle33 added this to the infra-team-sync-2024-12-17 milestone Dec 16, 2024
@MarkEWaite MarkEWaite removed this from the infra-team-sync-2024-12-17 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-permissions Request for GitHub permissiosn
Projects
None yet
Development

No branches or pull requests

5 participants