Merge pull request #1212 from jembi/hotfix

Hotfix

package.json

@@ -1,7 +1,7 @@
 {
   "name": "openhim-core",
   "description": "The OpenHIM core application that provides logging and routing of http requests",
-  "version": "8.3.0",
+  "version": "8.3.1",
   "main": "./lib/server.js",
   "bin": {
     "openhim-core": "./bin/openhim-core.js"

src/model/apps.js

@@ -11,9 +11,10 @@ const AppSchema = new Schema({
     required: true
   },
   description: String,
-  icon: {
-    data: Buffer,
-    contentType: String
+  icon: String,
+  type: {
+    type: String,
+    enum: ['link', 'embedded']
   },
   category: String,
   access_roles: [String],

test/integration/appsAPITests.js

@@ -20,7 +20,7 @@ describe('API Integration Tests', () => {
       name: 'Test app',
       description: 'An app for testing the app framework',
       icon: 'data:image/png;base64, <base64>',
-      type: 'link|embedded',
+      type: 'link',
       category: 'Operations',
       access_roles: ['test-app-user'],
       url: 'http://test-app.org/app',

test/unit/appsTest.js

@@ -0,0 +1,56 @@
+'use strict'
+
+/* eslint-env mocha */
+import should from 'should'
+
+import {getApps, updateApp} from '../../src/api/apps'
+import {AppModelAPI} from '../../src/model/apps'
+
+describe('Apps', () => {
+  afterEach(async () => {
+    await AppModelAPI.deleteMany({})
+  })
+
+  describe('getApps', () => {
+    it('should fail when retrieving from mongo fails', async () => {
+      const ctx = {
+        request: {
+          query: {}
+        }
+      }
+
+      await getApps(ctx)
+
+      ctx.status.should.equal(500)
+      should.exist(ctx.body.error)
+    })
+  })
+
+  describe('updateApps', () => {
+    it('should fail when updating in mongo fails', async () => {
+      const app = AppModelAPI({
+        name: 'Test app1',
+        description: 'An app for testing the app framework',
+        icon: 'data:image/png;base64, <base64>',
+        type: 'link',
+        category: 'Operations',
+        access_roles: ['test-app-user'],
+        url: 'http://test-app.org/app1',
+        showInPortal: true,
+        showInSideBar: true
+      })
+      await app.save()
+
+      const ctx = {
+        request: {
+          body: {}
+        },
+        status: 200
+      }
+
+      await updateApp(ctx, app._id)
+
+      should.exist(ctx.body.error)
+    })
+  })
+})