From 191d3c773e491021e479c927964bdf028fff4813 Mon Sep 17 00:00:00 2001
From: Bond_009 <bond.009@outlook.com>
Date: Fri, 29 Sep 2023 12:05:27 +0200
Subject: [PATCH] Update the TargetFrameworks

Targeting netstandard2.0 and net6.0 should be enough for the library as
that should support all currently supported verions of .Net Framework
(4.6.2+) and .NET (6.0+) while allowing it to compile on linux.

(Technically .NET Framework 3.5 Service Pack 1 is still supported but we
 currently don't support that anyway)

For the test projects I just went with the latest .NET version as .NET
5.0 isn't supported anymore.
---
 TMDbLib/TMDbLib.csproj                                | 11 +----------
 TMDbLibTests/TMDbLibTests.csproj                      |  4 ++--
 TMDbLibTests/UtilityTests/TaggedImageConverterTest.cs |  4 ++--
 TestApplication/TestApplication.csproj                |  2 +-
 4 files changed, 6 insertions(+), 15 deletions(-)

diff --git a/TMDbLib/TMDbLib.csproj b/TMDbLib/TMDbLib.csproj
index 438292c5..86bb6f9e 100644
--- a/TMDbLib/TMDbLib.csproj
+++ b/TMDbLib/TMDbLib.csproj
@@ -2,7 +2,7 @@
 
   <PropertyGroup>
     <Authors>LordMike;Naliath</Authors>
-    <TargetFrameworks>net45;netstandard2.1;netstandard2.0;netstandard1.2</TargetFrameworks>
+    <TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
     <AssemblyName>TMDbLib</AssemblyName>
     <PackageId>TMDbLib</PackageId>
     <Description>.NET Client library for The Movie Database (https://www.themoviedb.org/)</Description>
@@ -25,13 +25,4 @@
     <PackageReference Include="Newtonsoft.Json" Version="13.0.3" PrivateAssets="compile" />
   </ItemGroup>
 
-  <ItemGroup Condition=" '$(TargetFramework)' == 'net45' ">
-    <Reference Include="Microsoft.CSharp" />
-    <PackageReference Include="System.Net.Http" Version="4.3.4" />
-  </ItemGroup>
-
-  <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.2' ">
-    <PackageReference Include="System.Net.Http" Version="4.3.4" />
-  </ItemGroup>
-
 </Project>
diff --git a/TMDbLibTests/TMDbLibTests.csproj b/TMDbLibTests/TMDbLibTests.csproj
index f661369e..f99cc8b7 100644
--- a/TMDbLibTests/TMDbLibTests.csproj
+++ b/TMDbLibTests/TMDbLibTests.csproj
@@ -3,7 +3,7 @@
   <Import Project="..\_Imports\Test.targets" />
 
   <PropertyGroup>
-    <TargetFramework>net5.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
   </PropertyGroup>
 
   <ItemGroup>
@@ -18,7 +18,7 @@
     <PackageReference Include="xunit" Version="2.5.1" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.5.1" PrivateAssets="All" />
-    <PackageReference Include="Verify.Xunit" Version="14.14.1" />
+    <PackageReference Include="Verify.Xunit" Version="17.10.2" />
   </ItemGroup>
 
   <ItemGroup>
diff --git a/TMDbLibTests/UtilityTests/TaggedImageConverterTest.cs b/TMDbLibTests/UtilityTests/TaggedImageConverterTest.cs
index 50516389..6a26b5e4 100644
--- a/TMDbLibTests/UtilityTests/TaggedImageConverterTest.cs
+++ b/TMDbLibTests/UtilityTests/TaggedImageConverterTest.cs
@@ -81,8 +81,8 @@ public async Task TestJsonTaggedImageConverter(int personId)
                 else if (item.MediaType == MediaType.Season)
                     Assert.IsType<SearchTvSeason>(item.Media);
                 else
-                    Assert.False(true, $"Unexpected type {item.GetType().Name}");
+                    Assert.Fail($"Unexpected type {item.GetType().Name}");
             });
         }
     }
-}
\ No newline at end of file
+}
diff --git a/TestApplication/TestApplication.csproj b/TestApplication/TestApplication.csproj
index b71ef819..f0a6bbd9 100644
--- a/TestApplication/TestApplication.csproj
+++ b/TestApplication/TestApplication.csproj
@@ -3,7 +3,7 @@
   <Import Project="..\_Imports\Test.targets" />
 
   <PropertyGroup>
-    <TargetFramework>net5.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
     <OutputType>Exe</OutputType>
   </PropertyGroup>