Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support conditionally usage of modifier #239

Open
jelhan opened this issue Feb 20, 2024 · 0 comments
Open

Support conditionally usage of modifier #239

jelhan opened this issue Feb 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jelhan
Copy link
Owner

jelhan commented Feb 20, 2024

The modifier does not have cleanup logic. In most cases that's okay. The element is destroyed anyways when modifier is removed. But it likely breaks when the modifier is applied conditionally.

Adding cleanup logic in a destructor may have negative impact on performance. See emberjs/rfcs#1007 (comment) on that topic. We should investigate the trade-off before shipping.

Conditionally applying this modifier does not seem to be a common case. At least no one reported a bug regarding missing cleanup. We should make sure to not harm everyone for a theoretical bug affecting no actual use case.

@jelhan jelhan added the enhancement New feature or request label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant