-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post.id is not unique -- should we use post.url instead? #340
Comments
This issue has been automatically marked as stale because it has not been commented on for at least two months. The resources of the Jekyll team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial. This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions. |
@larsks With default configuration, your posts' ids would have been |
I just noticed this issue too, in a second feed for an events collection. There is no custom permalink set for this collection as far as I can tell, but the URLs for pages look like |
@bencomp Will you be able to set up a minimal repository that showcases the discrepancy reported? |
I think the issue is with Jekyll core, which for non-post collections does not make the date in the filename part of the URL.
Maybe this can be solved by adding permalink templates for collections. Let me try later this week. |
This issue has been automatically marked as stale because it has not been commented on for at least two months. The resources of the Jekyll team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial. This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions. |
I'm running
jekyll-feed
(0.15.1) with Jekyll version 3.9.0. The feed generated byjekyll-feed
uses the value ofpost.id
to create the unique id for each post. Unfortunately, this value appears to only consider the title slug, meaning that two different posts named like this:_posts/2021-04-02-something.md
_posts/2021-04-03-something.md
Will both have
post.id
set to<baseurl>/something
. This causes problems with feed readers, since they use the<id>
element to differentiate between posts.It's not clear to me if this is a Jekyll issue (why isn't
post.id
unique) or ajekyll-feed
issue (just usepost.url
instead ofpost.id
for the unique id).The text was updated successfully, but these errors were encountered: