Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP only feeds don't work #22

Open
EvanKrall opened this issue Jul 21, 2023 · 2 comments · May be fixed by #27
Open

HTTP only feeds don't work #22

EvanKrall opened this issue Jul 21, 2023 · 2 comments · May be fixed by #27

Comments

@EvanKrall
Copy link

I'm trying to follow http://radar.spacebar.org/f/a/weblog/rss/1 but cannot; When I go to https://mastofeeder.com/.well-known/webfinger?resource=acct:[email protected] I see no "rel":"self" link.

Am I doing something wrong?

@jehna
Copy link
Owner

jehna commented Jul 27, 2023

Hmm. It seems that the site is http-only, and Mastofeeder only supports https sites for the time being. I'll change the issue's title a bit to reflect the issue better

@jehna jehna changed the title Cannot access specific RSS feed HTTP only feeds don't work Jul 27, 2023
@jehna
Copy link
Owner

jehna commented Jul 27, 2023

I'll add a few thoughts about this here for future reference.

The real issue is, that the part of the code that guesses the correct interpretation of the dot-formatted username is getting a bit hairy:

let additionalExtension = ""; // TODO: Refactor, the logic is getting messy

I'm thinking that this part needs a bit of refactoring, preferably some kind of lightweight abstraction/DSL rather than a procedural approach. That approach should IMO support combining multiple choices into different combinations, e.g.

  • An URL can have http/https
  • An URL can end in ``/.rss/`.xml`

These two combinations already result in six different URLs:

So we'd need some kind of way to describe this, e.g.:

const choices = [
  prepend('http', 'https'),
  append('', '.xml', '.rss')
  // ....etc
]

and then some mechanism that produces all combinations of those and checks them until it finds a result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants