Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: adjust weight of bucket #1 #247

Open
jeffreykeller opened this issue Apr 24, 2022 · 1 comment
Open

Feature request: adjust weight of bucket #1 #247

jeffreykeller opened this issue Apr 24, 2022 · 1 comment

Comments

@jeffreykeller
Copy link

We noticed tonight that our song leaders seemed much louder than the other singers. I agree that giving the leader a higher weight makes sense, but I think it's too high for us. So, assuming you don't want to change the default, it would be nice to be able to override it in the Advanced tab. (How persistent are those changes, BTW?)

@jeffkaufman
Copy link
Owner

I agree that giving the leader a higher weight makes sense, but I think it's too high for us.

This is currently hardcoded as LEADER_BOOST:

LEADER_BOOST = friendly_volume_to_scalar(1.1)

If someone wanted to submit a change to make it configurable, I'd be happy to review.

How persistent are those changes, BTW?

Pretty sure it resets when everyone who's currently connected disconnects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants