Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedback for key signature and root key signature (Midi editor) #1168

Open
aefren opened this issue Nov 23, 2024 · 5 comments
Open

Fedback for key signature and root key signature (Midi editor) #1168

aefren opened this issue Nov 23, 2024 · 5 comments

Comments

@aefren
Copy link

aefren commented Nov 23, 2024

Hello . In Reaper , there are shortcuts to change the key signature and root key signature, but there's no feedback from Osara . Currently , the accessible way to change the key and root key signature is by using NVDA 's object navigator or JAWS ' mouse cursor, which disrupts the workflow.

@aefren aefren changed the title Fedback for key signature and root key signature Fedback for key signature and root key signature (Midi editor) Nov 23, 2024
@jcsteh
Copy link
Owner

jcsteh commented Nov 23, 2024

Thanks for reporting. It'd be helpful if you could provide details of exactly which actions you're talking about and what you would expect to be announced when you use them. Thanks.

@aefren
Copy link
Author

aefren commented Nov 26, 2024

Here are the actions:

  • Select next key signature root: changes from C to Cb, D, Db, E...
  • Select next key signature: changes to major, melodic minor, harmonic minor, natural minor, Dorian...

Desired behavior: It should announce the new key signature after executing the action.

Current behavior: Nothing is verbalized, although the action does take effect and can be verified using the NVDA object navigator or the mouse cursor in JAWS.

@ScottChesworth
Copy link
Collaborator

Pasting the nearest thing I could find in the API but I don't think this is what we need, @jcsteh?

bool MIDI_GetScale(MediaItem_Take* take, int* rootOut, int* scaleOut, char* nameOut, int nameOut_sz)

Get the active scale in the media source, if any. root 0=C, 1=C#, etc. scale &0x1=root, &0x2=minor 2nd, &0x4=major 2nd, &0x8=minor 3rd, &0xF=fourth, etc.

@jcsteh
Copy link
Owner

jcsteh commented Nov 26, 2024

Yeah, that should do it, hopefully.

@jcsteh
Copy link
Owner

jcsteh commented Nov 26, 2024

I'm hoping the nameOut parameter will provide a nice friendly name like "C major". Otherwise we'll have to invent our own by looking at the rootOut and scaleOut parameters, which is doable but annoying and will definitely require me to brush up on music theory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants