Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apr_int64_t is everywhere; length types need to be fixed #21

Open
jchampio opened this issue Dec 1, 2015 · 0 comments
Open

apr_int64_t is everywhere; length types need to be fixed #21

jchampio opened this issue Dec 1, 2015 · 0 comments

Comments

@jchampio
Copy link
Owner

jchampio commented Dec 1, 2015

apr_int64_t is used almost everywhere. Sometimes it's not needed (i.e. the WebSocket protocol version), sometimes an apr_size_t should be there instead (i.e. when calculating buffer sizes), and sometimes we should probably use apr_uint64_t because negative values are unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant