Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codenames Pictures #83

Open
zvikabh opened this issue Apr 15, 2020 · 14 comments
Open

Codenames Pictures #83

zvikabh opened this issue Apr 15, 2020 · 14 comments

Comments

@zvikabh
Copy link
Contributor

zvikabh commented Apr 15, 2020

Support for Codenames Pictures (perhaps as a separate language?) would be totally awesome. Are there any thoughts along these lines?
I'm willing to contribute a bunch of Codenames Pictures-like drawings of mine. I can also have a go at coding, but I'm not very experienced with Go, so any pointers on how to go about this would be awesome.

@jbowens
Copy link
Owner

jbowens commented Apr 17, 2020

I think it might be tricky to support without pretty extensive changes, but I agree it would be cool! I'll think on it...

@zvikabh
Copy link
Contributor Author

zvikabh commented Apr 17, 2020

Here's a quick fork for Codenames Pictures. I had to change some CSS to get the cards to be a bigger, so that the images are clearer. So in this fork there is no support for the ordinary Codenames. It should be possible to have the two working side by side, though. WDYT?

@nochkin
Copy link
Contributor

nochkin commented Apr 21, 2020

@zvikabh
I'm interested in your pictures integration. Under what license do you distribute those images?

@zvikabh
Copy link
Contributor Author

zvikabh commented Apr 21, 2020

That fork is just an example for illustrative purposes, I don't own the copyright for those images.

@nochkin
Copy link
Contributor

nochkin commented Apr 21, 2020

@zvikabh
I think in order to use your fork one way or another we have to have some pictures which can be used under an appropriate license.
Just a friendly suggestion to find out if you can actually distribute them publiclly even on your Github before you get into troubles. You never know, it's not 1990s :-)

@zvikabh
Copy link
Contributor Author

zvikabh commented Apr 21, 2020

I just wanted to illustrate that this is easy to do technically. I suppose you're right and to be safe, I removed the images.

@zvikabh
Copy link
Contributor Author

zvikabh commented Apr 24, 2020

OK, I set up a new version in which I carefully verified that all images are public domain. You can also try it out here: http://ec2-18-188-243-7.us-east-2.compute.amazonaws.com/

@nochkin
Copy link
Contributor

nochkin commented Apr 24, 2020

@zvikabh
Nice, I'm glad you found some public domain images for that.
I have my own fork where I started doing the same thing, but I could not find public domain images. Can I use yours? What source did you use?

@zvikabh
Copy link
Contributor Author

zvikabh commented Apr 24, 2020

Most are from freesvg.org, and a few from Wikipedia, some with a couple of minor tweaks of my own. You are welcome to use them.
You could also use PNGs which are much easier to find with a free license, but it doesn't look as nice.

@nochkin
Copy link
Contributor

nochkin commented Apr 24, 2020

I liked your idea to use SVG instead of PNG. Thanks for sharing.
During my research I even was able to find a repo here on Github of someone who just made a some pretty low quality pictures using a phone of the original stuff and hosting here :-)

@zvikabh
Copy link
Contributor Author

zvikabh commented Apr 24, 2020

Cool, LMK if you get some nice results with your fork.

@banool
Copy link

banool commented May 17, 2020

Hey fam, I have a functioning and hosted version of Codenames Pictures here: https://github.com/banool/codenames-pictures. This has been alive for maybe 1.5 years now. It's a fork of this repo and like you all predicted, I had to make pretty heavy, backwards-incompatible changes to the code. As such, I've fallen way behind master because it isn't feasible to pull the new code in without essentially rewriting it all (though I'd be interested to try some time).

It'd be interesting to see how the original project could be refactored to support pictures natively, perhaps with some easily overwritable component for each of the cells in the game board. I had to make backend changes to support serving up URLs instead of words also of course.

To get around attribution issues, my friends and I drew our own cards 🤠. There is also support for using custom images supplied by the user. For example, try putting http://csclub.uwaterloo.ca/~ke2mcbri/codenames/dcom_cropped.txt into the custom images box here: https://codenames-pictures.dport.me.

@nochkin
Copy link
Contributor

nochkin commented May 17, 2020

@banool,
I have a few ideas on how to make it backward-compatible, but did not have enough time to complete it. Too busy with other projects.
I liked your hand-drawings. That's a good idea. Some looks really funny.

@enurseitov
Copy link

Guys we should absolutely make CodeMEMES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants