Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBWS-4429] NPE when SOAP request with mismatched targetNameSpace is received #539

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

gaol
Copy link
Contributor

@gaol gaol commented Oct 10, 2024

Issue: https://issues.redhat.com/browse/JBWS-4429

This PR is based on #530 and adds a test case for it.

@gaol gaol requested a review from a team as a code owner October 10, 2024 12:25
@gaol
Copy link
Contributor Author

gaol commented Oct 10, 2024

@jimma would you please review ? thanks

@jimma jimma merged commit af019c1 into jbossws:main Oct 11, 2024
12 checks passed
@jimma
Copy link
Member

jimma commented Oct 11, 2024

Thanks @lvydra and @gaol !

Comment on lines +147 to +150
if (bop == null)
{
throw MESSAGES.missingBindingOperationForAuthorization();
}
Copy link
Member

@asoldano asoldano Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can move up this stuff by 1 line? @jimma

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @asoldano . This is better. I'll get this fixed in the next commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants