-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIAM-2881] Add a demo on how to rebuild default RH-SSO 7.5.X image to start using latest IBM Semeru 11 JDK. Also add a script to (re)generate the templates to use the new image stream #247
base: sso75-dev
Are you sure you want to change the base?
Conversation
@dale-fu @levicic PTAL once got a chance (I have tested the changes on single s390x / ppc64le hosts too, and they seems to WFM correctly there too AFAICT, but better to verify them on full OpenShift cluster on these architectures too) @andymunro PTAL at / review the associated Thanks to all of you for your time in advance! |
--name=sso75-openshift-rhel8-ibm-semeru-11-jdk \ | ||
--namespace=openshift \ | ||
--strategy=docker \ | ||
https://github.com/jboss-container-images/redhat-sso-7-openshift-image.git#sso75-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dale-fu @levicic JFTR, obviously, till the PR is merged, you will need to change the last line in the above command to point to my fork & corresponding branch instead of the form above. IOW, create new build as follows:
$ oc new-build \
--context-dir=jdk/ibm-semeru-open-11-jdk \
--image-stream=sso75-openshift-rhel8 \
--name=sso75-openshift-rhel8-ibm-semeru-11-jdk \
--namespace=openshift \
--strategy=docker \
https://github.com/iankko/redhat-sso-7-openshift-image.git#semeru
The rest of the proposed steps should work without additional changes AFAICT.
jdk/README.md
Outdated
* The Docker build strategy to use for build execution, and | ||
* The Git repository, branch name and particular context directory within the repository as the source of the build | ||
|
||
**Prerequisites** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.Prerequisites
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in latest version. Thanks for pointing out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.Prerequisites
@andymunro I will actually need to revert these changes back. The code isn't written in Asciidoc, but rather in Markdown syntax, so the dot before the string actually does nothing. See here, on how it's rendered:
Instead of Prerequisites, it's just '.Prerequisites' (IOW without any effects).
The same case for the other remaining strings, that were modified. Are you OK with returning the previous form?
Thanks, Jan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes, @iankko. Thanks.
@andymunro Fixed all of them, as suggested. Thanks! |
…Sign-On 7.5 container image to start using the latest version of IBM Semeru 11 Open Edition JDK (OpenJ9 JVM) instead of the default Red Hat OpenJDK 11 one. Also add a helper script to (re)generate the existing templates to start using the newly built image stream Also correct issues pointed out by Andrew Munro during PR review. Thanks, Andy! Moreover, add the existence of Registry Service Account, and installation of the default Red Hat Single Sign-On 7.5.X OpenShift image stream as requirements for the custom OpenShift build. Signed-off-by: Jan Lieskovsky <[email protected]>
Yes, of course; please change it back. Thanks for asking @iankko . |
curl --header "Accept: application/vnd.github.v3+json" --show-error --silent \ | ||
"https://api.github.com/repos/ibmruntimes/semeru11-binaries/releases/latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iankko Currently on our Z cluster, this is failing due to API rate limit exceeded.
Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:
[CLOUD-XYA] Subject
CONTRIBUTING.md
)Signed-off-by: Your Name <[email protected]>
- usegit commit -s