Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIAM-2881] Add a demo on how to rebuild default RH-SSO 7.5.X image to start using latest IBM Semeru 11 JDK. Also add a script to (re)generate the templates to use the new image stream #247

Open
wants to merge 1 commit into
base: sso75-dev
Choose a base branch
from

Conversation

iankko
Copy link
Collaborator

@iankko iankko commented Apr 29, 2022

[CIAM-2881] Add a demo on how to rebuild the standard Red Hat Single Sign-On
7.5 container image to start using the latest version of IBM Semeru 11 Open
Edition JDK (OpenJ9 JVM) instead of the default Red Hat OpenJDK 11 one.

Also add a helper script to (re)generate the existing templates to start
using the newly built image stream

Signed-off-by: Jan Lieskovsky <[email protected]>

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <[email protected]> - use git commit -s

@iankko
Copy link
Collaborator Author

iankko commented Apr 29, 2022

@dale-fu @levicic PTAL once got a chance (I have tested the changes on single s390x / ppc64le hosts too, and they seems to WFM correctly there too AFAICT, but better to verify them on full OpenShift cluster on these architectures too)

@andymunro PTAL at / review the associated README.md once got a chance. If there's something that should be updated, kindly let me know

Thanks to all of you for your time in advance!
Jan

--name=sso75-openshift-rhel8-ibm-semeru-11-jdk \
--namespace=openshift \
--strategy=docker \
https://github.com/jboss-container-images/redhat-sso-7-openshift-image.git#sso75-dev
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dale-fu @levicic JFTR, obviously, till the PR is merged, you will need to change the last line in the above command to point to my fork & corresponding branch instead of the form above. IOW, create new build as follows:

$ oc new-build \
     --context-dir=jdk/ibm-semeru-open-11-jdk \
     --image-stream=sso75-openshift-rhel8 \
     --name=sso75-openshift-rhel8-ibm-semeru-11-jdk \
     --namespace=openshift \
     --strategy=docker \
     https://github.com/iankko/redhat-sso-7-openshift-image.git#semeru

The rest of the proposed steps should work without additional changes AFAICT.

jdk/README.md Outdated
* The Docker build strategy to use for build execution, and
* The Git repository, branch name and particular context directory within the repository as the source of the build

**Prerequisites**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Prerequisites

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest version. Thanks for pointing out!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.Prerequisites

@andymunro I will actually need to revert these changes back. The code isn't written in Asciidoc, but rather in Markdown syntax, so the dot before the string actually does nothing. See here, on how it's rendered:

Instead of Prerequisites, it's just '.Prerequisites' (IOW without any effects).

The same case for the other remaining strings, that were modified. Are you OK with returning the previous form?

Thanks, Jan

jdk/README.md Outdated Show resolved Hide resolved
jdk/README.md Outdated Show resolved Hide resolved
jdk/README.md Outdated Show resolved Hide resolved
jdk/README.md Outdated Show resolved Hide resolved
jdk/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@andymunro andymunro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes, @iankko. Thanks.

@iankko
Copy link
Collaborator Author

iankko commented May 2, 2022

A few changes, @iankko. Thanks.

@andymunro Fixed all of them, as suggested. Thanks!

…Sign-On

7.5 container image to start using the latest version of IBM Semeru 11 Open
Edition JDK (OpenJ9 JVM) instead of the default Red Hat OpenJDK 11 one.

Also add a helper script to (re)generate the existing templates to start
using the newly built image stream

Also correct issues pointed out by Andrew Munro during PR review. Thanks,
Andy!

Moreover, add the existence of Registry Service Account, and
installation of the default Red Hat Single Sign-On 7.5.X OpenShift
image stream as requirements for the custom OpenShift build.

Signed-off-by: Jan Lieskovsky <[email protected]>
@andymunro
Copy link
Collaborator

Yes, of course; please change it back. Thanks for asking @iankko .

Comment on lines +17 to +18
curl --header "Accept: application/vnd.github.v3+json" --show-error --silent \
"https://api.github.com/repos/ibmruntimes/semeru11-binaries/releases/latest"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iankko Currently on our Z cluster, this is failing due to API rate limit exceeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants