Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow setting both d_sae and expansion_factor in config #47

Open
chanind opened this issue Mar 25, 2024 · 4 comments · Fixed by #301
Open

Don't allow setting both d_sae and expansion_factor in config #47

chanind opened this issue Mar 25, 2024 · 4 comments · Fixed by #301

Comments

@chanind
Copy link
Collaborator

chanind commented Mar 25, 2024

These are both ways of setting the size of the SAE

@anthonyduong9
Copy link
Contributor

I can work on this this week.

@anthonyduong9
Copy link
Contributor

anthonyduong9 commented Sep 22, 2024

@chanind I was thinking that as part of this, we should also change

expansion_factor: int = 4

to

expansion_factor: Optional[int] = None

since it's less explicit to check if expansion_factor is 4 than None to check if it's been set. However, people would always have to pass a value for either d_sae or expansion_factor when they instantiate LanguageModelSAERunnerConfig. What do you think?

@jbloomAus
Copy link
Owner

seems good

@chanind
Copy link
Collaborator Author

chanind commented Sep 22, 2024

I think that sounds reasonable! But just make sure that if both expansion_factor is None, and d_sae is None, then expansion_factor should default to 4 for backwards compatibility. This can be noted in the docstring and also as a comment after expansion_factor: Optional[int] = None # defaults to 4 if d_sae and expansion_factor is None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants