-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use logging instead of print in codebase #43
Comments
I can work on this this week. |
@chanind there are many tests and |
I feel like print is fine for jupyter notebooks, and agree, unit tests shouldn't have print statements ideally - prints in unit tests should be deleted. Maybe benchmark tests are OK to have print statements since we don't really run those except manually and rarely. |
Currently, logging info is output using
print()
, but this makes it hard to control the verbosity level of the output, and cannot distinguish between debugging / info statements and warnings / errors. For instance, in sae_training/config.py, creating a config object prints a lot of statements, but these are a mix of debugging / info / warnings, and would be better suited to using the Python logging module.The text was updated successfully, but these errors were encountered: