Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photos with lower-res don't fill view on iPhone 6 Plus #35

Open
andr3a88 opened this issue Jun 5, 2015 · 4 comments
Open

Photos with lower-res don't fill view on iPhone 6 Plus #35

andr3a88 opened this issue Jun 5, 2015 · 4 comments

Comments

@andr3a88
Copy link
Contributor

andr3a88 commented Jun 5, 2015

I'm have problems with low-resolution image (about 600px width, in lanscape mode ratio image > 1) that leaves black spaces on top and bottom. I'm using the last version on Github.

Example
ios simulator screen shot 05 giu 2015 10 55 13

@nartex
Copy link

nartex commented Jun 25, 2015

I had this problem too, I juste reverted the two tests in gestResizeRatioFromImage:width:height on line 327 and 353 from

if (widthDiff > heightDiff)

to

if (widthDiff < heightDiff)

@andr3a88
Copy link
Contributor Author

My JBKenBurs class reaches 343 lines. You mean inside "Wider than screen" or "No wider than screen"?
I tried many times but sometimes the problem comes back.

 // Wider than screen
if (image.size.width > frameWidth)
{
   ...
}
// No wider than screen
else
{
    ...
}

@crairdin
Copy link

I apologize for not figuring out how to actually fix this in GitHub but these three lines do everything getResizeRatioFromImage:width:height: fails to do in 50:

float hRatio = frameHeight / image.size.height;
float wRatio = frameWidth / image.size.width;

return hRatio > wRatio ? hRatio : wRatio;

@shahimclt
Copy link

simulator screen shot 15-jan-2016 6 43 06 pm
simulator screen shot 15-jan-2016 6 43 09 pm
simulator screen shot 15-jan-2016 6 43 13 pm

Same issue here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants