Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

menupage_panel does not include PrivacyModalPanel #390

Open
bmihelac opened this issue Apr 28, 2021 · 1 comment
Open

menupage_panel does not include PrivacyModalPanel #390

bmihelac opened this issue Apr 28, 2021 · 1 comment

Comments

@bmihelac
Copy link
Contributor

Privacy panel missing in settings tab for MenuPage and subclasses.

menupage_settings_panels is defined in https://github.com/rkhleics/wagtailmenus/blob/master/wagtailmenus/panels.py#L100-L107 and clearly it does not have PrivacyModalPanel.

As far as I can see PrivacyModalPanel is added to wagtail in v2.10:

wagtail/wagtail@84f3265

For the reference, missing panel is marked on the image:

privacy-panel
@benfroelich
Copy link
Contributor

Though PrivacyPanel is no longer added directly to settings_panels since this commit wagtail/wagtail@0693eed#diff-b15877f11b1b7e35b3dce47e57f8aff6dccac9a02f3f94caf860a5e51fd48360L1072, I am raising the same underlying issue here as it affects other panel contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmihelac @benfroelich