Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapting redis-py tox strategy #574

Open
WisdomPill opened this issue Dec 1, 2021 · 2 comments · May be fixed by #583
Open

Adapting redis-py tox strategy #574

WisdomPill opened this issue Dec 1, 2021 · 2 comments · May be fixed by #583
Labels
enhancement question

Comments

@WisdomPill
Copy link
Member

@terencehonles regarding tests,
lately I have been contributing a little to redis-py and I saw how they are using tox with docker for setting up the environment.
I find it very clean and elegant since you just need docker running and the test suite will take care of the rest.

Would you mind taking a look and get back to me?
I would like to have something similar in the future for django-redis as well.

Have a look here
@terencehonles
Copy link
Contributor

Thanks for the link, I'll try to look at this sometime soon, but a little busy at the moment. Thanks for handling the release 🙂

@WisdomPill
Copy link
Member Author

I would also add testing for the last supported versions of redis, which are described here.

I do not like the idea of increasing the testing matrix so much, so I guess now only 6.2 and 5.0 should be enough since they are the only ones who are going to get the security patches.

Last but not least I would test for redis-py 3 and redis-py 4, so a little bit of adaptation od documentation and tox is needed, I will try to have a look at least on using tox-docker this weekend

@WisdomPill WisdomPill linked a pull request Dec 23, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moving to tox-docker WisdomPill/django-redis
2 participants
@terencehonles @WisdomPill