-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PolymorphicInlineModelAdmin.get_child_inlines()
#576
Comments
Hi! Thanks for opening an issue! Please feel free to open a PR with a possible solution! |
I have already done an implementation, just only not fully sure if it's needed at all, once I get sure I'll do a PR. By the moment, I have at f075aab a fix to properly notify with a server side 500 error when there are no configured child models, instead of a non-sense 403 error. |
Sounds good! |
You have the PR at #582, you can review and comment it. I think it works properly, although would like to test it a bit more, specially I would ensure inlines are working properly because I'm having problems with them, I think it's about config on my side instead of a bug but want to ensure it. |
The same as
PolymorphicParentModelAdmin.get_child_models()
allows to dynamically get the child models withbase_model.__subclasses__()
, I would like to havePolymorphicInlineModelAdmin.get_child_inlines()
method that I can overwrite to get the inlines subclasses, and don't need to set them explicitly. This would allows me to have a cleaner code, and also prevent some circular references.The text was updated successfully, but these errors were encountered: