Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development backend #130

Open
pkaczynski opened this issue Aug 25, 2016 · 2 comments
Open

Add development backend #130

pkaczynski opened this issue Aug 25, 2016 · 2 comments

Comments

@pkaczynski
Copy link

It would be nice to have feature, such as in django-sendfile, to have some kind of development backend which does not specify a backend and basically does nothing with the response.

Maybe it is possible to configure SmartDownloadMiddleware like that? SMartDownloadMiddleware checks if BACKEND and RULES are difined. My goal is to have some kind of basic settings which is extended by local settings. However, having MIDDLEWARE_CLASSES in base settings makes it impossible to extend it in local ones.

@benoitbryon
Copy link
Collaborator

You are right, SmartDownloadMiddleware raises error if settings.DOWNLOADVIEW_BACKEND is not set.
And yes, a "development" backend would make it possible to avoid modifying MIDDLEWARE_CLASSES and just adapt DOWNLOADVIEW_BACKEND. Looks like a good idea :)

@benoitbryon
Copy link
Collaborator

Tagging as "medium priority" because it is not blocker. That said, it looks like a nice idea and a quite easy change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants