Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests for redis and email urls #332

Open
lilioid opened this issue Mar 18, 2022 · 1 comment · May be fixed by #333
Open

Update tests for redis and email urls #332

lilioid opened this issue Mar 18, 2022 · 1 comment · May be fixed by #333

Comments

@lilioid
Copy link
Member

lilioid commented Mar 18, 2022

django-cache-url and dj-email-url recently partially changed their behavior.
We should update our tests to reflect the changes.

In detail, the following changes have been made:
lilioid added a commit that referenced this issue Mar 24, 2022
@lilioid
fix failing 'test_email_url_value' test
42ab54f 
See #332
lilioid added a commit that referenced this issue Mar 24, 2022
@lilioid
fix failing 'test_cache_url_value' test
a7f0606 
The test failed for two reasons. One was me changing the error string in a previous commit which
I have adapted the test for now.
The other was that django-cache-url changed its behavior. See #332
@lilioid lilioid linked a pull request Mar 24, 2022 that will close this issue
Draft
4 tasks
@mgorny
Copy link

mgorny commented Jun 13, 2022

Ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve error related end-user experience jazzband/django-configurations
2 participants
@mgorny @lilioid