Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suboptimal TLS settings #7

Open
mdavids opened this issue Oct 6, 2023 · 1 comment
Open

Suboptimal TLS settings #7

mdavids opened this issue Oct 6, 2023 · 1 comment

Comments

@mdavids
Copy link

mdavids commented Oct 6, 2023

The TLS-settings seem suboptimal. For instance:

  • TLS1.0 is offered
  • TLS1.1 is offered
  • Possibly vulnerable for BEAST attack
  • Possibly vulnerable for SWEET32 attack
  • Possibly vulerable to LUCKY13 attack

Is seems to me there is some room for improvement here.

@RyanBlakeIT
Copy link

I'm not very familiar with how to request code changes into Github, so below is the diff for argus5/master/src/argus/web/web.go that will resolve these issues:

12a13
>       "crypto/tls"
110a112,129
>               TLSConfig: &tls.Config{
>                       PreferServerCipherSuites: true,
>                       CurvePreferences: []tls.CurveID{
>                               tls.CurveP256,
>                               tls.X25519,
>                       },
>                       CipherSuites: []uint16{
>                               tls.TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256,
>                               tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
>                               tls.TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384,
>                               tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
>                               tls.TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305,
>                               tls.TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305,
>                               tls.TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
>                               tls.TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
>                       },
>                       MinVersion: tls.VersionTLS12,
>               },
112,114c131,133
<       s.services = append(s.services, www)
<       s.done.Add(1)
<       return www
---
>               s.services = append(s.services, www)
>               s.done.Add(1)
>               return www

Just need to recompile after making the above change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants