Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build step in readme does not build python binding #17

Open
wenxuanou opened this issue Feb 1, 2023 · 0 comments
Open

Build step in readme does not build python binding #17

wenxuanou opened this issue Feb 1, 2023 · 0 comments

Comments

@wenxuanou
Copy link

wenxuanou commented Feb 1, 2023

In the original build step, the command cmake . --target build will do nothing anything after cmake . -B build, and will not build the python binding. Besides, cmake . -B build will create the build folder automatically and there is no need to manually create the folder.

The correct building commands should be:

git clone https://github.com/javedulu/ad-xolib.git
cd ad-xolib
git submodule update --init --recursive
cmake . -B build
cmake --build build

Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant