java.net.URI.toURI broken

[Harsh4902]

• Unit test for 'toURI' method

• Obtain working URI by fixing a dependency in the JPF model classes

• fixing issue java.net.URI.toURI broken #457

[Harsh4902]

@cyrille-artho please review this PR.

[cyrille-artho]

Good job!
As this test will fail without a fix in jpf-core, let's wait with merging the PR until Part 2 (the fix) is also ready.

[cyrille-artho]

Thanks for the update. This test is a good way to verify an upcoming fix of toURI. Once you have a fix for toURI, we can merge the PR.

[Harsh4902]

@cyrille-artho what should be the standard output of toURI method based on our use case in modbat?

[cyrille-artho]

We always use the regular JVM as a baseline. In this case, your test may fail because toURI seems to include the absolute path in the filename. Try to adapt the test case so that the assertion holds when you execute it on the regular JVM (without JPF), as we want the behavior under JPF to be equivalent.

[cyrille-artho]

You seem to have accidentally included an extra file.

[cyrille-artho]

Strange that the test passes while a simple program using toURI fails with JPF:
With this being Test.java:

import java.io.*;

public class Test {
  public final static void main(String[] args) throws Exception {
    File f = new File("test");
    System.out.println(f.toURI().toURL());
  }

I have run this with jpf +classpath=. Test and get the following:

gov.nasa.jpf.vm.NoUncaughtExceptionsProperty
java.lang.NoSuchMethodException: jdk.internal.misc.SharedSecrets.setJavaNetUriAccess(Ljdk/internal/misc/JavaNetUriAccess;)V
	at java.net.URI.<clinit>(URI.java:3626)
	at java.io.File.toURI(File.java:131)
	at Test.main(Test.java:6)

[cyrille-artho]

Make sure the tests run on JPF, not the host JVM:
https://github.com/javapathfinder/jpf-core/wiki/Writing-JPF-tests

[Harsh4902]

@cyrille-artho Please review it. Hopefully its resolved now.

[cyrille-artho]

Thanks, looks good!