Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gltf-obj converter, old version in pom.xml? #92

Open
lilithgrigoryan opened this issue Jun 8, 2023 · 1 comment
Open

gltf-obj converter, old version in pom.xml? #92

lilithgrigoryan opened this issue Jun 8, 2023 · 1 comment

Comments

@lilithgrigoryan
Copy link

I was going through your code in gltf-obj converter part, and noticed that material reader you're using here is from javagl.obj of old version 0.3.0. And some of the materials aren't treated as they should be (in my case the newer version of obj reader is doing well). I guess that's because of pom.xml of the package, here the obj library version is set to 0.3.0 (but I believe, the newest is 0.4.0). Maybe it is possible to update it to the newest?

@javagl
Copy link
Owner

javagl commented Jun 8, 2023

Your're right. The update from 0.3.0 to 0.4.0 was only done (relatively) recently. But the dependency is updated now, and that update will be part of the next release.

I'm a bit curious, though: There was a bit of uncertainty about the "best" or "right" approach for the extended material support on the OBJ library (that's one of many reasons why some of the changes behind the PR javagl/Obj#25 had been simmering on tbe backburner for ~6 years). And I wonder what exactly didn't work as expected for you with version 0.3.0. Have these MTL files been files that actually contained the PBR information that was exported from Blender?

Related: The jgltf-obj library should probably be reviewed so that it can handle this new PBR information more direcly. For now, I only applied the changes that have been necessary for the update itself (basically a few checks for the places where the Mtl class can now return null when no information was given). But if the input is an MTL with PBR information, then this could be converted into a glTF PBR material directly, without too many guesses, assumptions or default values.

This should not be toooo much effort, but I'll have to allocate a bit of time for that. I'll leave this issue open until this is addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants