Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking changes in FastBoot 1.0 #141

Closed
simonihmig opened this issue Jun 25, 2017 · 2 comments
Closed

Fix breaking changes in FastBoot 1.0 #141

simonihmig opened this issue Jun 25, 2017 · 2 comments
Labels

Comments

@simonihmig
Copy link

The current ember-cli-fastboot releases (1.0.0-rc.1 and above) introduce breaking changes. These will most likely break your current FastBoot implementation.

See ember-fastboot/ember-cli-fastboot#387 for more information and a guide on how to fix your addon. Also you may want to visit the -fastboot Slack channel to get help from other users.

Note: this issue has been created automatically, by searching for certain patterns in your code. If you think this has been falsely created, feel free to close!

@jasonmit
Copy link
Owner

This was fixed a few weeks back - are you noticing something not working?

Ref: 493b5ab

@simonihmig
Copy link
Author

are you noticing something not working?

@jasonmit No, as written above the issue was created automatically to inform all addon authors of those breaking changes. In you case it was triggered by https://github.com/jasonmit/ember-cli-moment-shim/blob/master/index.js#L16. But it seems you support beta and rc versions, so this can be ignored then. Sorry for the false alarm! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants