Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require srcDir if srcFiles and cssFiles are both empty #58

Open
sgravrock opened this issue Nov 9, 2024 · 0 comments
Open

Don't require srcDir if srcFiles and cssFiles are both empty #58

sgravrock opened this issue Nov 9, 2024 · 0 comments

Comments

@sgravrock
Copy link
Member

A typical ESM configuration doesn't load anything from srcDir and only sets it because it's a required field. That's unnecessary, and it can be confusing because there's no obviously correct value to use. (In practice, anything will work.) jasmine-browser-runner should only require srcDir if at least one of srcFiles or cssFiles is non-empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant