Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing static button images and using Quartz to render #39

Open
davisjp1822 opened this issue Dec 20, 2014 · 3 comments
Open

Removing static button images and using Quartz to render #39

davisjp1822 opened this issue Dec 20, 2014 · 3 comments

Comments

@davisjp1822
Copy link

Howdy-
Nice library! Thank you for posting it to Github.

Would you be willing to consider a Pull Request that removes the static images used as the backgrounds for the button states and instead uses added properties and Quartz rendering to change the appearance of the buttons? For example:

ios simulator screen shot dec 20 2014 10 41 49 am

@jasarien
Copy link
Owner

Sure, open a pull request and I'll give it a review.

@davisjp1822
Copy link
Author

Brainstorming on an elegant way to do this here. Would it be acceptable to add two properties to JSTokenField.h for the button customization? These two fields would be "buttonBackgroundColor" - which would disable the "setNormalBg" and "setHighlightedBg" calls in JSTokenButton - and "buttonCornerRadius", which would do the same. This is the straightforward approach, but I am not sure if it fits your coding style. What do you think?

@jasarien
Copy link
Owner

jasarien commented Jan 5, 2015

Yeah, I think that would be a decent approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants