Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility failing on Lighthouse #133

Open
devcer opened this issue Sep 22, 2022 · 2 comments
Open

Accessibility failing on Lighthouse #133

devcer opened this issue Sep 22, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@devcer
Copy link

devcer commented Sep 22, 2022

Describe the bug
Accessibility of masonic is failing. Most likely because role="gridcell" is not a child of role="row", instead it is a child of role="grid"

To Reproduce
Steps to reproduce the behavior:

  1. Go to example sandbox -> https://codesandbox.io/s/0oyxozv75v
  2. Open the preview in new window
  3. Open Devtools and click on Lighthouse
  4. Now select only accessibility test in desktop view and run lighthouse
  5. Check the analysis and you will see two accessibility errors.

Expected behavior
Masonic should be accessible

Screenshots
Screenshot 2022-09-22 at 8 12 42 AM

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: Macbook Pro
  • OS: v12.6
  • Browser - Chrome
  • Version 105.0.5195.125

Additional context

Elements that have role="gridcell" applied to them must be the child of an element with a role of row. -> https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/gridcell_role

https://dequeuniversity.com/rules/axe/4.4/aria-required-parent

@jaredLunde
Copy link
Owner

PRs welcome :)

@V3RON
Copy link
Contributor

V3RON commented Sep 28, 2022

I wonder if we should remove the role prop altogether and force list and listitem roles. Technically, the grid created by Masonic doesn't reassemble a table at all, but rather a list with styles applied to mimic a tabular layout. 🤔

@jaredLunde jaredLunde added the good first issue Good for newcomers label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants