Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge the resources tab with the warning if one exists #19

Open
Madis0 opened this issue Jan 25, 2020 · 3 comments
Open

Badge the resources tab with the warning if one exists #19

Madis0 opened this issue Jan 25, 2020 · 3 comments

Comments

@Madis0
Copy link
Contributor

Madis0 commented Jan 25, 2020

As of the SSLeuth redesign, the main popup is split to two tabs. That means the user can get confused if they see a warning symbol on the icon but no warnings on the main tab.

Hence, I suggest showing the warning icon on the Resources tab too (or make the tab yellow overall, per #18).

@Madis0 Madis0 changed the title Mark the resources tab with the warning if one exists Badge the resources tab with the warning if one exists Jan 25, 2020
@jannispinter
Copy link
Owner

I like the idea of colouring the resource tab yellow (or adding a badge to it), when there is a warning on the resource tab.

@grahamperrin
Copy link

Accessibility: colour alone may be insufficient to signal an alert.

@jannispinter
Copy link
Owner

I've added a warning triangle to the tab (if a warning exists) in commit 0f2d5c0.
grafik

I will publish a new minor release (0.1.1) with the fixes we discussed, thanks! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants