Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow cfunctions in argparse :map #158

Merged
merged 2 commits into from
Oct 29, 2023
Merged

allow cfunctions in argparse :map #158

merged 2 commits into from
Oct 29, 2023

Conversation

tionis
Copy link
Contributor

@tionis tionis commented Oct 26, 2023

Fixes #157

@sogaiu
Copy link
Contributor

sogaiu commented Oct 26, 2023

Thanks for this.

On a similar note, I wonder about this bit. I'm not too familiar with argparse (^^;

Any thoughts?

@tionis
Copy link
Contributor Author

tionis commented Oct 26, 2023

You mean :action?
This just executes the function at parse time

@sogaiu
Copy link
Contributor

sogaiu commented Oct 26, 2023

I guess so.

The thing is, it's also just checking via only function? -- wondering whether it would make sense to change that too.

pepe
pepe approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@pepe pepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pepe
Copy link
Member

pepe commented Oct 27, 2023

The thing is, it's also just checking via only function? -- wondering whether it would make sense to change that too.

This makes sense. Another PR will be fine I guess. Or @tionis do you think you can add it to this one, please?

@tionis
Copy link
Contributor Author

tionis commented Oct 27, 2023

I guess so.

The thing is, it's also just checking via only function? -- wondering whether it would make sense to change that too.

You're right! I just added the change

pepe
pepe approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@pepe pepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bakpakin bakpakin merged commit c03667e into janet-lang:master Oct 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepe pepe pepe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

in argparse, a cfunction cannot be used for :map
4 participants
@tionis @sogaiu @pepe @bakpakin