Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error with Reason files and uncaught exceptions #18

Open
Lupus opened this issue Mar 17, 2020 · 5 comments
Open

Syntax error with Reason files and uncaught exceptions #18

Lupus opened this issue Mar 17, 2020 · 5 comments
Labels
enhancement forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. help wanted

Comments

@Lupus
Copy link

Lupus commented Mar 17, 2020

Using ppx_expect v0.13.0, ppxlib 0.12.0, when exception happens in a test, ppx_expect generates invalid attribute:

[@@expect.uncaught_exn {|                                                                                                                                                   
.....
|}];

In Reason all attributes use single @ symbol.

@hhugo
Copy link

hhugo commented Apr 26, 2020

The logic writing the corrected file (in https://github.com/janestreet/ppx_expect/blob/master/matcher/matcher.ml) would need to be adjusted for reason files

@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label May 25, 2020
@ghost
Copy link

ghost commented Jun 3, 2020

@Lupus, happy to accept a patch to support reason.

@idkjs
Copy link

idkjs commented Jan 26, 2021

@Lupus have you figured this out?

@Lupus
Copy link
Author

Lupus commented Jan 26, 2021

Well, I just avoid promoting test runs that ended up with exceptions. Last time I did it just so that I can read it in IDE fully instead of looking at diff in the terminal, and them I ended up with Reason being unavailable to parse it back. Git helped me clear this out, not a big deal :)

@idkjs
Copy link

idkjs commented Jan 26, 2021

explains how the code otherwise compiles. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. help wanted
Projects
None yet
Development

No branches or pull requests

4 participants