Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in AD57X4R.cpp #8

Open
johnmx opened this issue May 27, 2024 · 4 comments
Open

Bug in AD57X4R.cpp #8

johnmx opened this issue May 27, 2024 · 4 comments

Comments

@johnmx
Copy link

johnmx commented May 27, 2024

I found a bug in AD57X4R.cpp. In the function writeMosiDatagramToChip(), instead of
Datagram mosi_datagram_n = mosi_datagram_array[chip];
it should be:
Datagram mosi_datagram_n = mosi_datagram_array[chip_n];

@peterpolidoro
Copy link
Member

Good find! I think I have that bug in several other places too. Probably explains why other people have been experiencing problems too. I have not had a chance to test this code on hardware. I am making a new version 5.0.1 with the bug fixes. Do you have hardware that you can use to confirm whether or not it works properly now? Thanks!

@johnmx
Copy link
Author

johnmx commented May 28, 2024

Yes, I tested the library on hardware, and it works. However, I only tested the sawtooth example.

@peterpolidoro
Copy link
Member

Thank you! Did you test it for one chip or multiple chips?

@johnmx
Copy link
Author

johnmx commented May 28, 2024

Only one chip: AD5724R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants