From b2e1752cbe591f3ec87fc6ca19eaf9505a2ae904 Mon Sep 17 00:00:00 2001 From: maynouf Date: Thu, 16 Nov 2023 13:23:04 +0100 Subject: [PATCH 1/2] fixed MutableSequence import from collections (it now is collections.abc) --- geomeppy/geom/polygons.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/geomeppy/geom/polygons.py b/geomeppy/geom/polygons.py index ce51e467..e086f450 100644 --- a/geomeppy/geom/polygons.py +++ b/geomeppy/geom/polygons.py @@ -1,5 +1,5 @@ """Heavy lifting geometry for IDF surfaces.""" -from collections import MutableSequence +from collections.abc import MutableSequence from itertools import product from math import atan2, pi from typing import Any, List, Optional, Tuple, Union # noqa From b255587957e3c263ec7c00999422090180032833 Mon Sep 17 00:00:00 2001 From: maynouf Date: Thu, 16 Nov 2023 13:56:44 +0100 Subject: [PATCH 2/2] fixed an error in documentation that made the tutorial not run properly --- docs/source/Start here.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/Start here.rst b/docs/source/Start here.rst index ebda8e7e..a320961e 100644 --- a/docs/source/Start here.rst +++ b/docs/source/Start here.rst @@ -102,7 +102,7 @@ Now we need to tell `geomeppy` to match up our surfaces with the correct outside Last step, let's add some nice big windows. We'll set window to wall ratio (WWR) of 0.6 for all external walls. - >>> idf.set_wwr(0.6) + >>> idf.set_wwr(0.6, construction="Project External Window") So what have we built? We can export the IDF geometry as an OBJ file, a format that can be imported into a 3D geometry viewer.