RollupDateLiteralTest Failing at Fiscal Quarter #324
Unanswered
shane-saltbox
asked this question in
Q&A
Replies: 1 comment 2 replies
-
I was able to successfully reproduce this issue by changing the Fiscal Year Start Month to February where shouldWorkForFiscalMonthFunction, shouldWorkForFiscalQuarterFunction, shouldWorkForLastFiscalYear, shouldWorkForLastNFiscalYears, shouldWorkForLastNQuarters, shouldWorkForLastQuarter, shouldWorkForNFiscalYearsAgo, shouldWorkForNQuartersAgo, shouldWorkForNextFiscalYear, shouldWorkForNextNFiscalYears, shouldWorkForNextNQuarters, shouldWorkForNextQuarter, shouldWorkForThisFiscalYear, shouldWorkForThisQuarter all failed. Were there any other additional changes or fails that I missed? |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
@jamessimone I'm attaching a quick analysis of what we found while trying to manually implement the test coverage for the package. We'd like to be able to use the plug-in now that I know it's there, but suspect that'll fail until we're able to address the issue we found.
For context, our business starts it's fiscal year in February, which has also been updated on the 'Fiscal Year Starts In' value to February.
While going through the install of the test classes several methods in RollupDateLiteralTest failed due to the use of THIS_QUARTER instead of THIS_FISCAL_QUARTER for example. We were able to get around most of them quickly by utilizing the fiscal date, but also had to make a few other changes / comment a few sections out. At the end of the day there was still a good code coverage after these changes.
I'm attaching a quick diff so it's easy for you to find what changes we had to make.
Let me know if you had any questions!
Beta Was this translation helpful? Give feedback.
All reactions