Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for target_label of Edge.addlabel #51

Open
dmismirn opened this issue Jan 9, 2022 · 1 comment
Open

fix for target_label of Edge.addlabel #51

dmismirn opened this issue Jan 9, 2022 · 1 comment

Comments

@dmismirn
Copy link

dmismirn commented Jan 9, 2022

Hello, team!

first of all thanks for the great module. In the process of using it, I noticed a small optimization for the code:

        if target_label is not None:
            self.add_label(source_label, model_name="six_pos", model_position="shead", preferred_placement="source_on_edge",
            border_color=label_border_color, background_color = label_background_color)

i would suggest the following changes (target_label and thead):

        if target_label is not None:
            self.add_label(target_label, model_name="six_pos", model_position="thead", preferred_placement="source_on_edge",
            border_color=label_border_color, background_color = label_background_color)

Thanks!

@hazbut
Copy link

hazbut commented Jun 17, 2022

slight correction to this proposal:

self.add_label(target_label, model_name="six_pos", model_position="ttail", preferred_placement="target_on_edge",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants