Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Add holidays #46

Open
leobetosouza opened this issue Sep 16, 2016 · 4 comments
Open

Add holidays #46

leobetosouza opened this issue Sep 16, 2016 · 4 comments

Comments

@leobetosouza
Copy link
Contributor

I know that holidays varies by country, state, city, province, etc

I think would be good have a way to set the holidays, with a array of month/date

For instance with the US federal holidays would be something like this moment.setHolidays(['January 01', 'January 18', 'February 15', 'July 04', 'May 30', 'September 5', 'October 10', 'November 11', 'November 26', 'December 26'])

For NY we would push some more days to the list: moment.addHolidays(['February 12', 'November 08', 'December 25'])

Them when we use methods of moment-bussiness it consider these days not as weekdays, and not as weekendDays.

We can also create methods to count holidays.

What do you think?

@jamesplease
Copy link
Owner

Makes sense to me. If you've got time to open a PR, I would review/merge it ✌️ But I won't have time to add the feature myself

@jakeleboeuf
Copy link

@jmeas anybody ever take a stab at a PR for this?

@jamesplease
Copy link
Owner

Not yet 🙂

@gndelia
Copy link

gndelia commented Mar 23, 2019

Is this alive ? If I created a PR, would there any time to review it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants