remove ifs around function expressions #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function expressions are hoisted outside of block scopes, in other words, JavaScript will define the functions anyway. Thus, the
HAS_UINT8ARRAY
andHAS_BUFFERS
if statements surrounding the functions do not play any role in this library.JavaScript bundlers, such as Webpack, are assuming you are trying to declare the function inside the if's block scope only to be used inside the if statement. Like so:
This causes the library to error out with "bufferCharCodeAt is not defined" error. Which can be quickly mitigated by understanding scope in JavaScript and removing the unnecessary if statements from function expression declarations.