You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, i need to use the LCH color space for an application and the package does not support it. I implemented it locally, with the same bounds checking as the other color models and i hit assertion errors because my application uses out of range colors as intermediaries while generating valid colors. I also noticed how redundant writing an color model became with all the assertions, which also are hardcoded, making it hard to refactor. So, how would we ago about this? Should i open an pr with all the bounds checking and then we address it later, with an way to disable it in the constructors or moving them to an separate static method for each space, so that constructors can call assert(ColorSpaceBounds.checkHsl(hue, saturation, lightness, allowOutOfBounds)), instead of manually checking each value in the constructor, toList, and other methods?
The text was updated successfully, but these errors were encountered:
Hey, i need to use the LCH color space for an application and the package does not support it. I implemented it locally, with the same bounds checking as the other color models and i hit assertion errors because my application uses out of range colors as intermediaries while generating valid colors. I also noticed how redundant writing an color model became with all the assertions, which also are hardcoded, making it hard to refactor. So, how would we ago about this? Should i open an pr with all the bounds checking and then we address it later, with an way to disable it in the constructors or moving them to an separate static method for each space, so that constructors can call assert(ColorSpaceBounds.checkHsl(hue, saturation, lightness, allowOutOfBounds)), instead of manually checking each value in the constructor, toList, and other methods?
The text was updated successfully, but these errors were encountered: