API server returns incorrect HTTP status code

[javibookline]

jambonz-api-server/lib/routes/api/error.js

Lines 16 to 18 in d33d0aa

	if (err.code === 'ER_DUP_ENTRY') {
	logger.info(err, 'duplicate entry on insert');
	return res.status(422).json({msg: err.message});

When trying to create a resource that already exists, the code returned is 422 (unprocessable resource) when it should return a 409 (conflict).

[javibookline]

The reason it is useful to return the proper code is that it enables better handling of the response - trying to insert something unprocessable should maybe trigger a manual review (i.e. when inserting a carrier bound to an account, the account does not exist) whereas inserting a duplicate entry does not require that, and automated flows benefit from this distinction.