Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This plugin seems not to work anymore. #19

Open
MichaelBrauner opened this issue Aug 29, 2020 · 6 comments
Open

This plugin seems not to work anymore. #19

MichaelBrauner opened this issue Aug 29, 2020 · 6 comments

Comments

@MichaelBrauner
Copy link

I am on the latest craft version and the |readTime(false) filter send back a TimeModel with 0 minutes and 0 seconds anytime.

I tried it on the entry (a blogentry with a matrix field).
And I tried it to use with the matrix field itself (wich holds a redactor field).
I did even try to use it directly on the matrix block itself (not on the array of blocks)

Nothing worked sadly :(.

@bymayo
Copy link

bymayo commented Sep 1, 2021

Having the same issue, read time returns 0 on all matrix fields regardless of if it has blocks or not.

@BrandKits
Copy link

I'm having no joy with the plugin either (Version 1.6.0 for Craft 3.8x).

{{ readTime(entry) }} returns 1 every time (even when changing read time setting to 5 wpm).

{{ readTime(entry.contentBuilder.all()) }} gives an exception: 'PHP Warning – strip_tags() expects parameter 1 to be string, array given'

A client requested a read time feature just this morning, was hoping for a quick solution!

@bymayo
Copy link

bymayo commented Mar 28, 2023

@BrandKits This plugin seems to be abandoned as we're still having issues 2 years later.

If your on Craft 4, we've moved to https://plugins.craftcms.com/reading-time?craft4

@jalendport
Copy link
Owner

Working on reproducing it on my end and getting a proper fix in place... Thanks for your patience!

@BrandKits
Copy link

@jalendport I would completely understand why you wouldn't want to spend time fixing an inherited plugin's old Craft 3 code when you have Craft 4 code working. But appreciate the effort, as I'd like to roll this out for my client. Thanks.

@jalendport
Copy link
Owner

@BrandKits well, I'm honestly not entirely sure this is not an issue for Craft 4 as well; I basically just made the code Craft 4 ready, so any bugs are probably still there. However, it seems this issue only affects a subset of the plugin's users, because there are people I know using it on both Craft 3 and 4 that haven't had problems (though it could be something as simple as they don't have matrix fields in the mix and I know at least the issue creator, Michael, does).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants