Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back tags feature for news section #1492

Open
Dexmaster opened this issue Jun 13, 2022 · 9 comments
Open

Adding back tags feature for news section #1492

Dexmaster opened this issue Jun 13, 2022 · 9 comments
Assignees

Comments

@Dexmaster
Copy link
Contributor

This is separate ticket for tags in news articles and /news/ section sidebar. Ticket created from discussion in issue #1321 #1321 (comment)

Expected behavior:

  1. at least similar functionality to previous tags:
    image
  2. provide information how authors can add tags to their news/announcements.

@ericpoirier @cesarhernandezgt @chrisguindon

@ericpoirier ericpoirier self-assigned this Jun 13, 2022
@ericpoirier
Copy link
Contributor

Hi @Dexmaster,

I added the tags to the following staging page:

https://deploy-preview-1575--jakartaee.netlify.app/news/

Let me know what you think and if there's anything else.

Thanks.

@Dexmaster
Copy link
Contributor Author

The main part I feel is different you don't see any changes when selecting tag (no breadcrumbs change or header change etc)
Also URL is less clean, just compare two urls:
https://deploy-preview-1575--jakartaee.netlify.app/news/?news_tags=Jakarta%20EE
https://deploy-preview-1202--jakartaee.netlify.app/news/tags/jakarta-ee/
#1575 Header/breadcrumbs part doesn't show any change, and it should...

@rstjames
Copy link

Hi @ericpoirier
The page is looking good. I would like to point out a couple things.

  • Dates: if its a single number it should be 0# example: September 08 2022
  • Date: if its the current year we hide it.
  • top header is structured differently
  • when clicking a tag it does not show up in the breadcrumb

@Dexmaster
Copy link
Contributor Author

Dexmaster commented Oct 25, 2022

Also related to #1321 eclipse newsroom API sends broken author data and breaks avatars in the news section
image

P.S. I can open separate issue if needed it's more #1321 related

@ericpoirier
Copy link
Contributor

Also related to #1321 eclipse newsroom API sends broken author data and breaks avatars in the news section image

P.S. I can open separate issue if needed it's more #1321 related

Yes, please open another issue for this. Thanks.

@ericpoirier
Copy link
Contributor

Thanks for the feedback @rstjames @Dexmaster. I'll look into how possible it is to make those changes since we are now using JS rather then Hugo to populate the Tags. Which is why the behaviour is currently different from what was on production. But I'll have a look at what my options are. Will keep you posted.

@ericpoirier
Copy link
Contributor

@rstjames I've looked into your comments a bit closer today and I would suggest opening a new issue if you'd like to update the look of the news page as this issue here is for the tags only but I did made an update to add the tag to the breadcrumb.

https://deploy-preview-1575--jakartaee.netlify.app/news/?news_tags=Wildfly

@Dexmaster as for the url, I was thinking that I could update the url parameter to look like: ?tags=[something] rather then ?news_tags=[something]. I know it's not as clean as the previous urls that we had but before we were using the taxonomy system in Hugo which created html pages. But if I can update the url parameter I think it's a good compromise.

It would look something like this:

jakarta.ee/news/?tags=[something]

Let me know what you think.

Thanks.

@ericpoirier
Copy link
Contributor

@Dexmaster can you have a look at my last comment and see if what i'm proposing is good?

Thanks.

@Dexmaster
Copy link
Contributor Author

Dexmaster commented Jan 27, 2023

@ericpoirier I still see an issue when I change both params:
image
If you go by UI news-type should be news-filter or news_filter or filter.
And tags should be the same style snake_case kebab-case or just term would be fine. Just consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Work In Progress
Development

No branches or pull requests

3 participants