-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding back tags feature for news section #1492
Comments
Hi @Dexmaster, I added the tags to the following staging page: https://deploy-preview-1575--jakartaee.netlify.app/news/ Let me know what you think and if there's anything else. Thanks. |
The main part I feel is different you don't see any changes when selecting tag (no breadcrumbs change or header change etc) |
Hi @ericpoirier
|
Thanks for the feedback @rstjames @Dexmaster. I'll look into how possible it is to make those changes since we are now using JS rather then Hugo to populate the Tags. Which is why the behaviour is currently different from what was on production. But I'll have a look at what my options are. Will keep you posted. |
@rstjames I've looked into your comments a bit closer today and I would suggest opening a new issue if you'd like to update the look of the news page as this issue here is for the tags only but I did made an update to add the tag to the breadcrumb. https://deploy-preview-1575--jakartaee.netlify.app/news/?news_tags=Wildfly @Dexmaster as for the url, I was thinking that I could update the url parameter to look like: ?tags=[something] rather then ?news_tags=[something]. I know it's not as clean as the previous urls that we had but before we were using the taxonomy system in Hugo which created html pages. But if I can update the url parameter I think it's a good compromise. It would look something like this: jakarta.ee/news/?tags=[something] Let me know what you think. Thanks. |
@Dexmaster can you have a look at my last comment and see if what i'm proposing is good? Thanks. |
@ericpoirier I still see an issue when I change both params: |
This is separate ticket for tags in news articles and /news/ section sidebar. Ticket created from discussion in issue #1321 #1321 (comment)
Expected behavior:
@ericpoirier @cesarhernandezgt @chrisguindon
The text was updated successfully, but these errors were encountered: