Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arbitrary number of steps #13

Open
jagrosh opened this issue Oct 11, 2022 · 0 comments
Open

Support for arbitrary number of steps #13

jagrosh opened this issue Oct 11, 2022 · 0 comments

Comments

@jagrosh
Copy link
Owner

jagrosh commented Oct 11, 2022

As things stand right now, most lyrics sources require 2 steps, a 'search' step that attempts to find a URL to a page with the lyrics, and a 'parse' step that fetches the contents at that URL and deciphers the page into usable lyrics. One source currently precedes this with a 'token' step that fetches a token that is used for future lookups.

I have concerns about how maintainable enforcing these steps will be long-term. Additionally, there are some potential lyrics sources that don't require both search and parse steps, such as https://some-random-api.ml/lyrics . I think an ideal setup would be to support an arbitrary number of steps, with the 'result' of each step (be it a token, a URL, etc) be available to all future steps, and the final step always attempting to return valid lyrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant