From d641e36fbc9f315b5d2d8dc690ac6ec5aaf4db4b Mon Sep 17 00:00:00 2001 From: FlamingSaint Date: Wed, 24 Jul 2024 23:10:18 +0530 Subject: [PATCH] Add changes Signed-off-by: FlamingSaint --- cmd/jaeger/internal/extension/jaegerquery/server.go | 4 ++-- cmd/jaeger/internal/extension/jaegerquery/server_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/jaeger/internal/extension/jaegerquery/server.go b/cmd/jaeger/internal/extension/jaegerquery/server.go index 7dd7242a841..c2221175d79 100644 --- a/cmd/jaeger/internal/extension/jaegerquery/server.go +++ b/cmd/jaeger/internal/extension/jaegerquery/server.go @@ -69,7 +69,7 @@ func (s *server) Start(_ context.Context, host component.Host) error { } qs := querysvc.NewQueryService(spanReader, depReader, opts) - mqs, err := s.createMetricStorage(host) + mqs, err := s.createMetricReader(host) if err != nil { return err } @@ -128,7 +128,7 @@ func (s *server) addArchiveStorage(opts *querysvc.QueryServiceOptions, host comp return nil } -func (s *server) createMetricStorage(host component.Host) (metricsstore.Reader, error) { +func (s *server) createMetricReader(host component.Host) (metricsstore.Reader, error) { if s.config.MetricStorage == "" { s.telset.Logger.Info("Metric storage not configured") return disabled.NewMetricsReader() diff --git a/cmd/jaeger/internal/extension/jaegerquery/server_test.go b/cmd/jaeger/internal/extension/jaegerquery/server_test.go index 0dfb8f41b49..e51f7c697b1 100644 --- a/cmd/jaeger/internal/extension/jaegerquery/server_test.go +++ b/cmd/jaeger/internal/extension/jaegerquery/server_test.go @@ -324,7 +324,7 @@ func TestServerAddMetricsStorage(t *testing.T) { if tt.extension != nil { host = storagetest.NewStorageHost().WithExtension(jaegerstorage.ID, tt.extension) } - _, err := server.createMetricStorage(host) + _, err := server.createMetricReader(host) if tt.expectedErr == "" { require.NoError(t, err) } else {