-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help upgrading from raven-js #2412
Comments
I can take this up. I'll do this first, and then the other bug for spans (in case someone doesn't solve that yet.) I'll come up with a plan |
Ok, so I went through @sentry/browser, and tried integrating it. I feel the work is same if we change it to @sentry/browser, or just re write functionality internally, however having a package means added scope for development in the future. I do prefer re writing the functions internally tho. But I'm not sure how to structure the files in that case? Where to write the new functions (under what folder) and testing them. If there is a method for this, I'll propose an idea for re writing the internal functions. |
I am not opposed to just switching to |
but if we're talking about like 10 lines of code that I'd rather re-implement than pull a separate dependency |
It won't be 10 lines of code tho. Right now the biggest issue I've faced is the lack of a direct shift from Perhaps I'll open a draft PR with changes I've done so far and you can comment on them? I am yet to migrate the biggest file |
Migration in progress Signed-off-by: Muthukumar <[email protected]>
We are using a deprecated https://www.npmjs.com/package/raven-js package in packages/jaeger-ui/src/utils/tracking/. Maybe we can use
@sentry/browser
for that, or maybe we can just implement the needed functionality internally since we use it only to capture some basic error information to submit to the tracking backend.The text was updated successfully, but these errors were encountered: