Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O with Horn (U+01A0) #2

Closed
jacobxperez opened this issue Oct 13, 2023 · 22 comments
Closed

O with Horn (U+01A0) #2

jacobxperez opened this issue Oct 13, 2023 · 22 comments
Assignees
Labels
help wanted Extra attention is needed missing glyph(s) Glyph(s) are missing
Milestone

Comments

@jacobxperez
Copy link
Owner

jacobxperez commented Oct 13, 2023

O with horn Ơ U+01A0 and ơ U+01A1

Original issue: Vietnamese glyphs and Please add support for Vietnamese language

@jacobxperez jacobxperez added the missing glyph(s) Glyph(s) are missing label Oct 13, 2023
@jacobxperez jacobxperez added the help wanted Extra attention is needed label Oct 14, 2023
@RandomMaerks
Copy link
Collaborator

Hey Jacob!
I see that you're looking for help on Vietnamese support. Is it okay if I contribute to the project?
I'm Vietnamese, and I (kinda) know how to use FontForge (just ignore my own repos, they're in a terrible state right now)

@jacobxperez
Copy link
Owner Author

jacobxperez commented Oct 18, 2023

@RandomMaerks Yes!! one of my aims with this project is to complete the Vietnamese language, let me start a branch just for you

@jacobxperez
Copy link
Owner Author

jacobxperez commented Oct 18, 2023

@RandomMaerks The Vietnamese branch is ready

@jacobxperez
Copy link
Owner Author

@RandomMaerks Let me know if you need anything else

@RandomMaerks
Copy link
Collaborator

Thanks for the preparation!
Progress might be slow since I'm incredibly busy this month, but I'll make sure to keep it up-to-date.

@RandomMaerks
Copy link
Collaborator

@RandomMaerks Let me know if you need anything else

I might have a couple of questions when I'm working on the fonts, but I think I'm good for now

@jacobxperez
Copy link
Owner Author

@RandomMaerks alright, thanks for your support, I'll be glad to answer any question

@RandomMaerks
Copy link
Collaborator

A little preview of the Vietnamese character set (AHP Regular):
image
image

@jacobxperez
Copy link
Owner Author

@RandomMaerks Wow!! this is absolutely beautiful!! I love it.

@jacobxperez jacobxperez unpinned this issue Oct 20, 2023
@jacobxperez jacobxperez pinned this issue Oct 20, 2023
@RandomMaerks
Copy link
Collaborator

Vietnamese characters and kerning have been implemented for AH Regular and Italic.
The source files have been uploaded to the Vietnamese branch

image
image

@jacobxperez
Copy link
Owner Author

@RandomMaerks Wow!! It looks beautiful. I love it

@jacobxperez jacobxperez added this to the v1.4.0 milestone Oct 29, 2023
@jacobxperez
Copy link
Owner Author

@RandomMaerks Hey how are you doing and thanks for everything the Vietnamese update is looking awesome. I am just wondering if you have any updates for the Bold and Bold Italic style.

@RandomMaerks
Copy link
Collaborator

Oh sorry for not updating you on the progress D:
I'm working on Bold, and everything is almost done. I just need to add kerning to the Vietnamese glyphs.

I might have more time to work on it tomorrow. I'll try my best to keep you updated 👍

@jacobxperez
Copy link
Owner Author

@RandomMaerks Thats awesome thanks, no worries take your time

@RandomMaerks
Copy link
Collaborator

A preview of Vietnamese glyphs (AHP Bold - with kerning)

image
image

The original 'breve' mark is really thin and doesn't match with other marks, so I thickened it slightly and made it a bit wider.

@jacobxperez hope you like the change

@RandomMaerks
Copy link
Collaborator

Also the change in question:

image

@jacobxperez
Copy link
Owner Author

@RandomMaerks Wow!! Yes they look perfect 👍

@RandomMaerks
Copy link
Collaborator

AHP Bold & Bold Italic are all finished. Sources and generated fonts have been uploaded to the vietnamese branch.

Here are some examples that I made:
ahp-a1
ahp-a2
ahp-a3

@jacobxperez if you find any problems, please let me know

@RandomMaerks
Copy link
Collaborator

Additional documentation about the set ↓↓

image

image

@jacobxperez
Copy link
Owner Author

@RandomMaerks Wow this is amazing you went beyond any expectations. It was one of my goals to add Vietnamese language support to Atkinson, thanks it's perfect the typography looks beautiful. I will start preparing everything for v1.4.0 and release it later this week.

jacobxperez added a commit that referenced this issue Nov 5, 2023
Completes the Vietnamese language #2 #3
@github-project-automation github-project-automation bot moved this from In Progress to Done in Vietnamese Language Support Nov 5, 2023
@jacobxperez jacobxperez unpinned this issue Nov 5, 2023
@RandomMaerks
Copy link
Collaborator

just under two years ago, i used the original atkinson hyperlegible fonts for my assignment. i complained that it didn't have vietnamese glyphs back then

can't believe i'd be the one to do the job two years later

@jacobxperez
Copy link
Owner Author

@RandomMaerks That's awesome, me too I got frustrated that google wasn't doing anything to update the original typeface so I took it upon my self, to do it. Your are always welcome to contribute to this project, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed missing glyph(s) Glyph(s) are missing
Projects
No open projects
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants