Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basepath (commonprefix) yields incorrect result when folders start with same letters #124

Open
RonaldTreur opened this issue Oct 28, 2014 · 0 comments
Open

Basepath (commonprefix) yields incorrect result when folders start with same letters #124

RonaldTreur opened this issue Oct 28, 2014 · 0 comments

Comments

@RonaldTreur
Copy link
Collaborator

Passing along files:
src/styles/main
src/styles/modules

yields the following (incorrect) basePath:
/absolute/path/src/styles/m

Suffice to say this is not correct and breaks the execution right away on fs.statSync(options.basePath)
RonaldTreur added a commit to RonaldTreur/styledocco that referenced this issue Oct 28, 2014
@RonaldTreur
Fixes jacobrask#124: Requires path separator in basepath
3af86ac 
By making sure the common path ends with a path separator, we know we end up with an actual valid base path.
RonaldTreur added a commit to RonaldTreur/styledocco that referenced this issue Dec 1, 2014
@RonaldTreur
Fixes jacobrask#124 for Node versions < 0.10
d8ae60b
RonaldTreur added a commit to RonaldTreur/styledocco that referenced this issue Dec 1, 2014
@RonaldTreur
Undo previous commit: Fixes jacobrask#124 for Node versions < 0.10
0cd73e4
This was referenced Jan 13, 2015
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RonaldTreur